Repository navigation
Conversation
Only og:type, the article times and article:author were rendered, so an article lost its section and tags, a book's authors became article:author, and profile, music and video pages had no type-specific tags. og:determiner, og:country_name, og:ttl and an image's secure_url were dropped too.
|
This pull request was not reviewed automatically because its author does not have write access to this repository. A maintainer with write access can start a review by commenting |
@vinext/cloudflare
create-vinext-app
@vinext/types
vinext
@cloudflare/workers-response-store
commit: |
Contributor
Performance benchmarksCompared 1 improved · 0 regressed · 6 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openGraphrenders onlyog:type, the article times andarticle:author, whatever the type. Next.js renders a set of tags per type:openGraph.typearticlearticle:expiration_time,article:section,article:tagbookbook:isbn,book:release_date,book:author,book:tagarticle:author, rest missingprofileprofile:first_name,last_name,username,gendermusic.*music:duration,album,song,musician,creator,release_datevideo.movie,video.episodevideo:actor,director,writer,duration,release_date,tag,seriesog:determiner,og:country_name,og:ttl,og:image:secure_url,twitter:image:secure_urlA single value where Next.js accepts one or a list (
authors: new URL(...)) also answers 500 on main.This change ports the type switch of
createMetadataElements(packages/next/src/lib/metadata/metadata.tsx). Without a type, the article times and authors are still rendered as before (Next.js renders them only fortype: "article").Verification
16 pages covering each type: with this change the type-specific tags equal Next.js 16.2.6 (
next start) in content and order onvite preview, and on workers.dev for the six pages checked there. One input differs on purpose: Next.js splits a single-stringsongsinto characters; this renders one tag.Tests
tests/features.test.ts: one case per type with the tags Next.js renders, plus the four basic fields.